Fix -Werror=maybe-uninitialized warning in bmp5_get_fifo_data#9
Open
heblushabus wants to merge 1 commit intoboschsensortec:masterfrom
Open
Fix -Werror=maybe-uninitialized warning in bmp5_get_fifo_data#9heblushabus wants to merge 1 commit intoboschsensortec:masterfrom
heblushabus wants to merge 1 commit intoboschsensortec:masterfrom
Conversation
Fix -Werror=maybe-uninitialized warning in bmp5_get_fifo_data
There was a problem hiding this comment.
Pull request overview
Resolves a GCC -Werror=maybe-uninitialized build failure in the BMP5 driver by explicitly initializing a local FIFO length variable before it is populated via an out-parameter.
Changes:
- Initialize
fifo_lento0inbmp5_get_fifo_data()to eliminatemaybe-uninitializedwarnings at higher optimization levels.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling with GCC on higher optimization levels (like -O2 or -Os) alongside
-Werror, the compiler throws amaybe-uninitializederror forfifo_leninbmp5_get_fifo_data().Initializing
fifo_lento0resolves this compiler error and ensures safer behavior without affecting the logic, as it is populated by reference viabmp5_get_fifo_len()immediately after.