Skip to content

bug: Halifax GAP reporting false positives #215

Description

@boscorat

Summary

This is another side effect of the opening balance issue on Halifax current accounts.
Statements where the opening balance don't match the prior statement closing balance get flagged as a gap.
We've fixed this from a checks & balances perspective in PR #211, and also from a transaction balance perspective, but we stopped short of changing the opening balance on the statement header record in order to preserve consistency with the physical PDF statement itself.

Solution

When we re-calculate the opening balance using the method in PR #211 we need to also over-write the actual statement header value with our newly calculated value before writing to the parquet files and the database. We should also log that this has happened.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions