Pull request for issue #18#19
Draft
google-labs-jules[bot] wants to merge 2 commits into
Draft
Conversation
The `--groupby` command-line argument was not being parsed correctly, causing issues when the column name contained special characters like '/'. The argument was being treated as a sequence of characters instead of a single string. This change modifies the `import_cmd` function in `src/odoo_data_flow/__main__.py` to split the `groupby` string by commas, allowing for both single-column names with special characters and multiple comma-separated columns to be parsed correctly into a list of strings. Additionally, new tests have been added to `tests/test_import_threaded.py` to verify the fix and prevent future regressions. The `noxfile.py` was also updated to ensure the `pydoclint` linter runs correctly within the `pre-commit` session.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
When a user explicitly specifies fields to defer using the `--deferred-fields` command-line option, the import process would previously accept this list without validation. This caused an issue when a 'required' field was deferred, as the first pass of the import would fail with a 'Missing required value' error from Odoo. This change introduces a validation step in the `importer.py` module. Before the import begins, the list of user-specified deferred fields is checked against the Odoo model's field definitions. Any field marked as 'required' is removed from the deferral list and processed in the first pass. A warning is logged to inform the user of this action. A new unit test has been added to `tests/test_importer.py` to verify this behavior.
bosd
force-pushed
the
feature/prevent-defer-required-fields
branch
from
1a00131 to
e7c4c00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18
PR created automatically by Jules for task 18046055512024637350