feat: 큐레이션 장소 검색 스펙 연동 - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 제목 (Title)
변경 사항 (Changes)
placeName필드 주입을 제거했습니다.kakaoPlaceId는 화면에 노출하지 않고, 장소 선택 시 payload에만 매핑합니다.barAddress와 프로그램address에 선택 주소를 매핑합니다.kakaoPlaceId빈값은 payload에서 제외합니다.변경 이유 (Reason for Changes)
bottle-note/workspace#348의 장소 검색 계약 변경에 맞춰, UI는placeName중심으로 제공하고 Kakao 장소 ID는 서버 전송용 값으로만 유지합니다.테스트 방법 (Test Procedure)
pnpm exec vitest run src/pages/curation/whisky-tasting-event/__tests__/whisky-tasting-event.form-model.test.ts src/pages/curation/whisky-tasting-event/__tests__/whisky-tasting-event.mapper.test.ts src/pages/curation/components/__tests__/CurationFormFieldRenderer.test.tsxpnpm run build통과git diff --check통과참고 사항 (Additional Information)
pnpm lint는 이번 변경과 무관한 기존 e2e/상세 화면 파일의 오류로 실패합니다.