Conversation
Signed-off-by: hgkim <hgkim@openerd.com>
Closed
13 tasks
… 생성하도록 수정 - 변경 불가능한 리스트를 직접 수정해서 발생하던 UnsupportedOperationException을 해결
Whale0928
previously approved these changes
Jun 26, 2025
Whale0928
left a comment
Whale0928
left a comment
Collaborator
There was a problem hiding this comment.
전체적으로 준수하게 구현되엇는대 관습을 좀더 맞추죠
특정한 형태가 일관성있게 유지된다면
Claude code 사용중이면 코드 베이스를 탐색해서 기존 타입 매칭을 하는것도 좋습니다.
Whale0928
self-requested a review
June 26, 2025 13:54
Contributor
Author
|
@Whale0928 집에 물새는 이슈가 있어서 수리하느라 PR제출에 좀 늦었습니다 ㅜㅜ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #{이슈-번호}
https://github.com/bottle-note/bottle-note-api-server/issues/406#event-18229260893
해결하려는 문제가 무엇인가요?
RCA 룰
r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)