Skip to content

feat: 큐레이션 장소를 Kakao Place ID로 교체 #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Whale0928 merged 1 commit into from
Jul 28, 2026
Merged

feat: 큐레이션 장소를 Kakao Place ID로 교체 #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions bottlenote-mono/src/main/resources/openapi/curation/program.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@
"x-field-style": "address-search",
"x-display-name": "장소명"
},
"zipCode": {
"kakaoPlaceId": {
"type": "string",
"description": "행사 장소 우편번호",
"example": "06164",
"minLength": 5,
"maxLength": 5,
"pattern": "^\\d{5}$",
"description": "Kakao Places 장소 ID",
"example": "27288225",
"minLength": 1,
"maxLength": 20,
"pattern": "^\\d+$",
"x-field-style": "address-search",
"x-display-name": "우편번호"
"x-display-name": "Kakao 장소 ID"
},
"address": {
"type": "string",
Expand Down
28 changes: 14 additions & 14 deletions bottlenote-mono/src/main/resources/openapi/curation/whisky_tasting_event.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@
"x-field-style": "address-search",
"x-display-name": "장소명"
},
"zipCode": {
"kakaoPlaceId": {
"type": "string",
"description": "장소 우편번호",
"example": "06236",
"minLength": 5,
"maxLength": 5,
"pattern": "^\\d{5}$",
"description": "Kakao Places 장소 ID",
"example": "27288225",
"minLength": 1,
"maxLength": 20,
"pattern": "^\\d+$",
"x-field-style": "address-search",
"x-display-name": "우편번호"
"x-display-name": "Kakao 장소 ID"
},
"barAddress": {
"type": "string",
Expand Down Expand Up @@ -312,15 +312,15 @@
"description": "피드에서 시음회 장소명을 표시하기 위해 포함한다."
}
},
"zipCode": {
"kakaoPlaceId": {
"type": "string",
"description": "장소 우편번호",
"example": "06236",
"minLength": 5,
"maxLength": 5,
"pattern": "^\\d{5}$",
"description": "Kakao Places 장소 ID",
"example": "27288225",
"minLength": 1,
"maxLength": 20,
"pattern": "^\\d+$",
"x-field-style": "address-search",
"x-display-name": "우편번호"
"x-display-name": "Kakao 장소 ID"
},
"barAddress": {
"type": "string",
Expand Down
47 changes: 30 additions & 17 deletions ...te-mono/src/test/java/app/bottlenote/curation/service/CurationPlaceFieldContractTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,22 +34,24 @@ void requestSpec_placeSearchFields_useAddressSearchStyle() throws IOException {
JsonNode tasting = OBJECT_MAPPER.valueToTree(schema(TASTING, "Request")).path("properties");
assertThat(tasting.path("placeName").path("x-field-style").asText())
.isEqualTo("address-search");
assertThat(tasting.path("zipCode").path("x-field-style").asText()).isEqualTo("address-search");
assertThat(tasting.path("kakaoPlaceId").path("x-field-style").asText())
.isEqualTo("address-search");

JsonNode program = OBJECT_MAPPER.valueToTree(schema(PROGRAM, "Request")).path("properties");
assertThat(program.path("placeName").path("x-field-style").asText())
.isEqualTo("address-search");
assertThat(program.path("address").path("x-field-style").asText()).isEqualTo("address-search");
assertThat(program.path("zipCode").path("x-field-style").asText()).isEqualTo("address-search");
assertThat(program.path("kakaoPlaceId").path("x-field-style").asText())
.isEqualTo("address-search");
}

@Test
@DisplayName("placeName과 zipCode는 optional이라 기존 required 계약을 늘리지 않는다")
@DisplayName("placeName과 kakaoPlaceId는 optional이라 기존 required 계약을 늘리지 않는다")
void requestSpec_newFields_areOptional() throws IOException {
JsonNode required = OBJECT_MAPPER.valueToTree(schema(TASTING, "Request")).path("required");

assertThat(required).hasSize(8);
assertThat(required.toString()).doesNotContain("placeName").doesNotContain("zipCode");
assertThat(required.toString()).doesNotContain("placeName").doesNotContain("kakaoPlaceId");
}

@Test
Expand All @@ -62,32 +64,43 @@ void validate_whenLegacyPayloadHasNoPlaceName_passes() throws IOException {
}

@Test
@DisplayName("zipCode가 5자가 아니면 검증이 거부한다")
void validate_whenZipCodeLengthIsNotFive_rejects() throws IOException {
@DisplayName("kakaoPlaceId가 빈 문자열이면 검증이 거부한다")
void validate_whenKakaoPlaceIdIsBlank_rejects() throws IOException {
Map<String, Object> payload = legacyPayload();
payload.put("kakaoPlaceId", "");

var errors = validator.validate(new MapBackedSchema(schema(TASTING, "Request")), payload);

assertThat(errors).isNotEmpty();
}

@Test
@DisplayName("kakaoPlaceId가 숫자가 아니면 검증이 거부한다")
void validate_whenKakaoPlaceIdIsNotDigits_rejects() throws IOException {
Map<String, Object> payload = legacyPayload();
payload.put("zipCode", "123");
payload.put("kakaoPlaceId", "2728A225");

var errors = validator.validate(new MapBackedSchema(schema(TASTING, "Request")), payload);

assertThat(errors).isNotEmpty();
}

@Test
@DisplayName("zipCode가 숫자 5자리가 아니면 검증이 거부한다")
void validate_whenZipCodeIsNotFiveDigits_rejects() throws IOException {
@DisplayName("kakaoPlaceId가 20자리를 넘으면 검증이 거부한다")
void validate_whenKakaoPlaceIdExceedsMaxLength_rejects() throws IOException {
Map<String, Object> payload = legacyPayload();
payload.put("zipCode", "0623A");
payload.put("kakaoPlaceId", "123456789012345678901");

var errors = validator.validate(new MapBackedSchema(schema(TASTING, "Request")), payload);

assertThat(errors).isNotEmpty();
}

@Test
@DisplayName("숫자 5자리 zipCode는 통과한다")
void validate_whenZipCodeIsFiveDigits_passes() throws IOException {
@DisplayName("20자리 숫자 kakaoPlaceId는 통과한다")
void validate_whenKakaoPlaceIdAtMaxLength_passes() throws IOException {
Map<String, Object> payload = legacyPayload();
payload.put("zipCode", "06236");
payload.put("kakaoPlaceId", "12345678901234567890");

var errors = validator.validate(new MapBackedSchema(schema(TASTING, "Request")), payload);

Expand Down Expand Up @@ -131,18 +144,18 @@ void responseSpec_placeNameFeedOrder_sitsBetweenTimeAndAddress() throws IOExcept
}

@Test
@DisplayName("피드에는 placeName이 실리고 zipCode는 실리지 않는다")
void extractFeedPayload_exposesPlaceNameButNotZipCode() throws IOException {
@DisplayName("피드에는 placeName이 실리고 kakaoPlaceId는 실리지 않는다")
void extractFeedPayload_exposesPlaceNameButNotKakaoPlaceId() throws IOException {
Map<String, Object> payload = legacyPayload();
payload.put("placeName", "보틀노트 테이스팅룸");
payload.put("zipCode", "06236");
payload.put("kakaoPlaceId", "27288225");

JsonNode feedPayload =
OBJECT_MAPPER.valueToTree(
projector.extractFeedPayload(schema(TASTING, "Response"), payload));

assertThat(feedPayload.path("placeName").asText()).isEqualTo("보틀노트 테이스팅룸");
assertThat(feedPayload.has("zipCode")).isFalse();
assertThat(feedPayload.has("kakaoPlaceId")).isFalse();
}

@Test
Expand Down
Loading