fix: 전역 다크모드 canvas 및 테마 상태 동기화 - #773
Draft
bottlenote-app[bot] wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈 (Related Issue)
PR 타입 (Type of Change)
변경 사항 (Changes)
<html>pre-hydration script에서 저장된/시스템 테마를 해석하고darkclass 및color-scheme을 적용했습니다.<body>하위 wrapper가 아닌document.documentElement를 동기화하도록 변경하고, 시스템/라이트/다크 preference를 지원합니다.변경 이유 (Reason for Changes)
<body>하위에만 적용되고 primary layout이bg-white를 강제하여/explore,/announcement등에서 흰 canvas가 남았습니다.스크린샷 (Screenshots)
/settings,/explore,/announcement의 dark canvas 전환 확인. preview 배포 대기테스트 방법 (Test Procedure)
pnpm test --runInBand --silent— 42 suites, 241 tests 통과pnpm lint— 통과 (기존 경고만 존재)pnpm build:dev— 더미 API endpoint 환경에서 컴파일·타입검사·정적 생성 통과<html>.dark,color-scheme: dark, canvas 배경을 확인/explore,/announcement에서 기존bg-white요소의 computed background가 white가 아닌 semantic dark surface/canvas인지 확인셀프 체크리스트 (Self Checklist)
pnpm lint통과참고 사항 (Additional Information)
pr-preview라벨을 추가하여 preview 배포를 요청합니다./api/auth/session401이 발생하므로, 인증 데이터가 필요한 화면의 콘텐츠 검증은 preview에서 별도로 확인합니다.