Skip to content

content: approve meta line shows chitin's verdict on the queuer - #73

Open
bdelanghe wants to merge 1 commit into
mainfrom
copy/approve-meta-queuer-line
Open

bdelanghe wants to merge 1 commit into
mainfrom
copy/approve-meta-queuer-line

Conversation

@bdelanghe

@bdelanghe bdelanghe commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

chitin's signed queue intent (bdelanghe/chitin#84) verifies who queued an intent. The approve page's meta line then gets {by} = chitin's queuer.line (e.g. work-x (seat, key 1ee5c2d9, origin seat) or work-x (unverified: no signature)). The fixed "(unverified)" suffix would contradict a verified queuer, so this change drops it.

This is the upstream for chitin's pinned copy (crates/chitin-approve/copy/strings.pin.json). The file is byte-for-byte the one on chitin#84. Once this merges, chitin bumps the pin to the merge commit.

  1. Independent PR. Verified: one string and its description.
  2. Changed codepaths verified. Verified: chitin-approve page test on chitin#84.
  3. Root cause identified. The copy assumed every queuer was unverified.
  4. No duplication. N/A.
  5. No unrelated changes. N/A.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

…ries chitin's verdict on the queuer (chitin signed queue intent)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 3, 2026 16:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants