feat(router): add php 8 attributes support for route definition#349
Open
gessyken wants to merge 4 commits intobowphp:5.xfrom
Open
feat(router): add php 8 attributes support for route definition#349gessyken wants to merge 4 commits intobowphp:5.xfrom
gessyken wants to merge 4 commits intobowphp:5.xfrom
Conversation
Member
|
Why did you avoid environment loading errors. This is the best observability pattern to know if the .env.json or the .env define |
Contributor
Author
You're right. I added the try-catch to avoid duplicate errors in tests, Fixed - try-catch only checks if env is already loaded, but |
Member
|
Ah!ok, you can reach out the env config into tests/Config for getting more information. |
papac
reviewed
Jan 4, 2026
| * @return Router | ||
| */ | ||
| public function register(string|array $controllers): Router | ||
| { |
Member
There was a problem hiding this comment.
$controllers = (array) $controllers;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for defining routes using PHP 8 attributes on controller classes.
Controllers can use #[Controller] attribute with prefix and middleware, and methods
can use #[Get], #[Post], #[Put], #[Delete], #[Patch] attributes to define routes.
The Router::register() method automatically discovers and registers routes from
controller classes. Includes 22 tests.