This repository was archived by the owner on Aug 2, 2026. It is now read-only.
Repository navigation
chore: withdrawn - #26
Closed
jameshgordy wants to merge 4 commits into
Closed
jameshgordy wants to merge 4 commits into
jameshgordy wants to merge 4 commits into
Conversation
The same engine compiled as a software instrument (AU aumu BbRt / VST3 Instrument / AAX SWGenerators): drop it on an instrument track, feed the DI via the side-chain (Logic) or key input (Pro Tools), and route every mixer strip to its own aux — the Ultrabeat workflow, for a bass rig. One shared processor, compiled twice: a second juce_add_plugin target (BoRBassRouter, BOR_INSTRUMENT=1) re-lists the same sources, and every divergence is an #ifdef. Buses: inputs "DI In" (stereo, Logic side-chain element / VST3 routing) + "Key In" (mono at input bus 1 — the JUCE AAX wrapper's sidechain contract); outputs "Mix" (identical to the effect, glue and all) + 9 default-disabled stereo stems (8 strips + DI), post-fader/pan/phase/mute/solo, pre-glue/pre-output-gain. The input collapse sums per-bus averages so a silent unconnected bus cannot halve the level; numOut becomes main-bus-width so the legacy extra-channel clear can never zero a stem. MIDI is accepted (hosts require it on instrument tracks) and ignored. No Standalone (would duplicate the effect's). Sessions/presets interchangeable between the two targets. Packaging: the macOS pkg/dmg and Windows installer now carry both plugins (no new release asset names); the Linux VST3 zip gains the Router bundle; CI pluginvals both VST3s. Verified: bor-bench fnv all 8 fingerprints byte-identical (incl. GUITAR — the shared input-stage restructure is float-identical), auval -v aufx BbEn BxRl PASS (effect regression), auval -v aumu BbRt BxRl PASS (multi-bus config probing), BoRBassRouter_AAX builds against AAX SDK 2.9.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Closed
# Conflicts: # Source/PluginProcessor.cpp
James, in Logic with Ultrabeat open: the Router must mirror it exactly. The six voicing stems (SUB, both LOW CLEANs, 57, 421, TWEETER) are now ALWAYS MONO with no in-plugin pan — panning is the Logic channel strip's job, so the Router hides those pan pots and mixes them dead centre. The rooms keep stereo stems (host may collapse to mono) and their pans; the DI gets a mono stem. In the AU build the stems are mandatory: the instrument picker offers ONLY the Multi Output configuration and the mixer -/+ spawns the aux strips, exactly like Ultrabeat. AAX/VST3 keep the disabled-stem fallback their wrappers require. Verified: fnv fingerprints byte-identical (effect untouched), auval aumu BbRt PASS with the 13-channel layout, auval aufx BbEn PASS. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jameshgordy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn.