Conversation
- Updated cmake_minimum_required to 3.10. - Modernized CMakeLists.txt by replacing global definitions and flags with target-based configuration (target_compile_definitions, target_compile_options, target_include_directories). - Fixed a dependency error in examples/CMakeLists.txt where test_proxy was unconditionally added to the examples target's dependencies. - Removed the unused tools directory and its reference in the root CMakeLists.txt. - Adopted modern CMake features like CMAKE_C_STANDARD and CMAKE_C_VISIBILITY_PRESET. Co-authored-by: boytm <5652342+boytm@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Updated cmake_minimum_required to 3.10 per user request. - Modernized CMakeLists.txt by replacing global definitions and flags with target-based configuration (target_compile_definitions, target_compile_options, target_include_directories). - Fixed a dependency error in examples/CMakeLists.txt where test_proxy was unconditionally added to the examples target's dependencies. - Removed the unused tools directory and its reference in the root CMakeLists.txt (contains lambda-pp, an unused C lambda preprocessor). - Adopted modern CMake features like CMAKE_C_STANDARD and CMAKE_C_VISIBILITY_PRESET. Co-authored-by: boytm <5652342+boytm@users.noreply.github.com>
1 participant
This PR upgrades the CMake build system to version 3.10 and modernizes the project configuration. Key changes include:
add_definitions,add_definitions(-fvisibility=hidden)) with target-specific equivalents (target_compile_definitions,CMAKE_C_VISIBILITY_PRESET).examplestarget depended ontest_proxyeven when threading was disabled.toolsdirectory and its associated targets, which were identified as unused.evhtptarget.PR created automatically by Jules for task 3913545006291041527 started by @boytm