Skip to content

Deprecate agent inbox delivery - #918

Merged
olegbrok merged 1 commit into
mainfrom
agent/deprecate-agent-inbox
Jul 27, 2026
Merged

Deprecate agent inbox delivery#918
olegbrok merged 1 commit into
mainfrom
agent/deprecate-agent-inbox

Conversation

@bradbrok

@bradbrok bradbrok commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

Deprecates the agent inbox delivery system in favor of live injection only.

  • Agent messages are retained in messages for audit/thread history, with legacy inbox rows kept read-only (read=1) only for recipient authorization/bookkeeping.
  • Startup retires any legacy unread rows; inbox/read/summary surfaces are inert and check_inbox returns a deprecation notice.
  • Removes wake-time inbox replay and unread reminder generation.
  • Makes auto-routed agent replies a one-way live injection (route_reply=False) so the existing inbox-only return leg is not lost and cannot ping-pong.
  • Reports a failed per-call transport handoff as not delivered; confirmed remains observability only.

Design choice

This is a clean behavioral deprecation rather than a feature flag. The SQLite schema is retained surgically because group/broadcast thread authorization and audit history use recipient mappings; those rows can never become unread delivery state.

Validation

  • ruff check .
  • python3 -m compileall -q src/pinky_daemon src/pinky_self
  • affected regression: 709 passed
  • CPython 3.12.13 full repository suite with declared .[dev] dependencies: 4,425 passed / 3 skipped
  • git diff --check

The production daemon already owns shared-MCP port 8890 on this host; one test that deliberately enables shared MCP emits an expected thread warning, without a test failure.

Deployment

No merge, release, deploy, daemon restart, or live write performed. Barsik owns merge, release cut, and update_and_restart.

@bradbrok bradbrok left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PINNED INDEPENDENT GAUNTLET — PASS

Frozen coordinates:

  • head: 1e6c7c6
  • tree: 600c34bacfd33210f23f01c116c202d242a354a5
  • sole parent / base / merge-base: 5848de0
  • branch: agent/deprecate-agent-inbox
  • divergence: 0 behind / 1 ahead

I validated this exact commit from a wholly fresh network clone, detached at the pinned SHA with a clean tracked tree. The 16-file (+330/-571) delta behaviorally deprecates durable agent-inbox delivery: new recipient bookkeeping is always read=1, legacy unread rows retire at startup, inbox/read/summary and check_inbox compatibility surfaces are inert, wake replay and unread nags are absent, failed live handoffs are not reported queued, and the auto-routed return leg uses route_reply=False for a one-way live injection while retaining audit/thread authorization bookkeeping.

Independent results:

  • CPython 3.11.15 affected regression: 709 passed
  • CPython 3.12.13 full repository suite: 4,425 passed / 3 skipped
  • CPython 3.13.14 affected regression: 709 passed
  • outside-repository adversarial harness on 3.11 / 3.12 / 3.13: 12/12 each
  • Ruff; compileall over src + tests; git diff --check; git fsck --full --strict: PASS
  • sdist + wheel build; fresh CPython 3.12 wheel install/import/core behavior: PASS
  • GitHub frozen-head checks: Python 3.11/3.12/3.13, Ruff, frontend+i18n, CodeQL Python/JS, Docker amd64 smoke and arm64 build all SUCCESS (release-only multi-arch push intentionally skipped)

The full local suite emitted only the known non-failing thread warning when the one shared-MCP test attempted port 8890 already owned by the production daemon.

No blocking findings.

This PASS is non-transferable: any head, tree, parent/base, merge-base, or branch-ref drift requires a wholly fresh detached exact-SHA gauntlet and a new pinned artifact. No merge, release, deploy, restart, staging, runner, or live-system write was performed.

@olegbrok
olegbrok marked this pull request as ready for review July 27, 2026 23:52
@olegbrok
olegbrok merged commit 9f5e037 into main Jul 27, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants