Replace Brave Search with Grok for the LLM-shaped route - #36
Merged
Merged
Conversation
Swap the brave engine back to Grok (https://grok.com/?q={q}) across the corpus, benchmark labels, generated config/embeddings, tests, and README. Brad uses Grok for longer agentic questions; Brave had replaced it in 3e341f7. Bump EMBEDDINGS_VERSION to 16. Routing eval unchanged: semantic 98.9%, keyword 97.5% (353-query benchmark). All 173 Playwright tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://grok.com/?q={q}), reversing 3e341f7 on top of the current (post-overhaul) corpus — Grok is the better fit for longer agentic questionsbrave→grokinscripts/search_phrases.json(engine def, bangs!g !gr !p !px, 5 keyword rules, 176-phrase route) and in the 87 benchmark labels; natural-language uses of "brave" in corpus phrases are untouchedsearch-config.json+search-embeddings.json(823 vectors) and bumpEMBEDDINGS_VERSIONto 16grok.comand the README engine tableValidation
python3 scripts/eval_routing.py: semantic 98.9% (349/353), keyword/lite 97.5% (344/353) — identical to baseline, same 4 known residual misroutesnpm run lintclean (eslint, ruff, config validator)npm test: 173 passed, 11 skipped, including the live keyword-mode navigation test now landing on grok.com🤖 Generated with Claude Code