Repository navigation
test(e2e): fix flaky magic wand smooth test on CI WebKit - #2
Merged
Merged
Conversation
The marching ants animation repaints the selection overlay every frame. In CI's software-rendered WebKit on 2 vCPUs this starved the wand worker: the smooth slider rebuild took 4 to 5 s instead of about 0.5 s and the "smooth slider reshapes the current selection outline" poll hit its 5 s timeout on iPad. Reduced motion stops the ants; outline geometry and assertions are unchanged.
Deploying rastertrace with
|
| Latest commit: |
02ec9b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://640b73b9.rastertrace.pages.dev |
| Branch Preview URL: | https://fix-ci-wand-ants-cpu.rastertrace.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smooth slider reshapes the current selection outlinetimed out on the iPad project in CI (runs 40963448224 and 40963421951, jobe2e (3)):Timeout 5000ms exceeded while waiting on the predicate. The same code passed on 10dba50, so this is a flake, not the decode change.mcr.microsoft.com/playwright:v1.62.1-noblewith--cpus=2: 3 of 4 runs failed.magicwand.spec.mjsruns withcontextOptions: { reducedMotion: "reduce" }. The app already stops the ants under reduced motion. Assertions and timeouts are unchanged. A top-leveltest.use({ reducedMotion })had no effect in 1.62.1, so it has to go throughcontextOptions..playwright-artifactsis a hidden folder. Addedinclude-hidden-files: true.Verification
--repeat-each=10passed 10/10;magicwand.spec.mjson both projects with--repeat-each=2passed 40/40.npm test: 321 pass.Not verified