"cpunet" goes at the end of the preimage, not the beginning #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the position of the "cpunet" prefix in the block hash calculation, moving it from the beginning to the end of the preimage data as indicated by the title.
- Moves the "cpunet\0" string from before the header fields to after them in the hash calculation
- Corrects the order of data being hashed to match the expected protocol specification
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sansh2356
approved these changes
Sep 9, 2025
Sansh2356
left a comment
Sansh2356
left a comment
There was a problem hiding this comment.
Indeed causing the block hash mismatch on server side .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.