Syncing from upstream OCA/connector (19.0)#465
Merged
Conversation
Class ``TransactionComponentCase.setUp()`` was not calling ``super()`` because of an inheritance issue: ``odoo.tests.common.TransactionCase.setUp()`` was not calling ``super()`` either. Since the issue has been solved, the test setup can be improved, allowing subclasses that inherit from ``TransactionComponentCase`` to correctly resolve the chain of ``super().setUp()`` calls.
Commit 96d9f26 improved test setup, but introduced a bug: the components registry was never flagged as 'ready' anymore. This commit fixes such bug.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #465 +/- ##
==========================================
- Coverage 84.56% 84.55% -0.02%
==========================================
Files 43 43
Lines 2657 2654 -3
Branches 159 159
==========================================
- Hits 2247 2244 -3
Misses 375 375
Partials 35 35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt_gitbot