Add tests for download CLI to improve coverage#599
Open
mani6409 wants to merge 2 commits into
Open
Conversation
Author
|
please look into it. |
Member
|
Hi @mani6409, thanks for your contribution, but we have a lot of PRs to review. It may take us some time to get to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Bug fix
Addition of a new feature
Other
Addition of unit tests for the download CLI.
Why is this PR needed?
The download CLI functionality previously had limited test coverage. Adding tests ensures that the command-line interface for downloading models behaves as expected and helps prevent regressions in future changes.
What does this PR do?
Adds unit tests for the download CLI module located in cellfinder/core/download/cli.py.
Verifies correct argument parsing and configuration behaviour.
Improves overall test coverage for the download functionality.
Ensures the CLI continues to behave correctly when parameters such as --install-path, --model, and --no-amend-config are used.
References
No related issue. This PR focuses on improving test coverage for the download CLI.
How has this PR been tested?
The new tests were executed locally using pytest.
The full project test suite was run to ensure no existing functionality was affected.
All tests passed successfully.
Is this a breaking change?
No. This PR only introduces additional tests and does not modify existing functionality.
Does this PR require an update to the documentation?
No documentation updates are required, as this change only adds test coverage.
Checklist:
The code has been tested locally
Tests have been added to cover new functionality
The documentation has been updated to reflect any changes (not required)
The code has been formatted with pre-commit