Add 2D input support for detection with clear guardrails#606
Open
Aayannoori15 wants to merge 1 commit into
Open
Add 2D input support for detection with clear guardrails#606Aayannoori15 wants to merge 1 commit into
Aayannoori15 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request (PR), please read the contributing guide.
Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)
Description
What is this PR
Why is this PR needed?
To allow 2D microscopy inputs to run through the detection pipeline safely. This unblocks users working with single‑plane data and provides clear guardrails around unsupported 2D classification.
What does this PR do?
Accepts 2D inputs for detection and treats them as a single z‑plane.
Forces z‑dependent filter parameters to 1 in 2D mode.
Pads voxel_sizes from (y, x) to (1.0, y, x) for 2D.
Adds guardrails and clearer errors in the main pipeline and classifier entry point for 2D usage.
Please reference any existing issues/PRs that relate to this PR.
How has this PR been tested?
None yet
Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.
Is this a breaking change?
No. Existing 3D workflows are unchanged. 2D inputs now have explicit validation.
If this PR breaks any existing functionality, please explain how and why.
No. Existing 3D workflows are unchanged. The new logic only activates for 2D inputs and adds explicit validation/guardrails.
Does this PR require an update to the documentation?
Yes. Usage docs should mention that 2D detection is supported but classification is not yet implemented for 2D.
If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.
Checklist: