feat: Add instrumentation for @mistralai/mistralai#1730
Open
Luca Forstner (lforst) wants to merge 9 commits intomainfrom
Open
feat: Add instrumentation for @mistralai/mistralai#1730Luca Forstner (lforst) wants to merge 9 commits intomainfrom
@mistralai/mistralai#1730Luca Forstner (lforst) wants to merge 9 commits intomainfrom
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
|
I think we should instrument https://github.com/mistralai/client-ts/blob/main/docs/sdks/fim/README.md as well. |
Member
Author
Sorry, forgot to mention in the PR desrciption. It's also instrumented. |
Abhijeet Prasad (AbhiPrasad)
approved these changes
Apr 2, 2026
| metadata: Record<string, unknown>; | ||
| } { | ||
| const params = getMistralRequestArg(args); | ||
| const { messages, ...metadata } = params || {}; |
There was a problem hiding this comment.
do we want to put everything into metadata? or make this an allowlist of fields?
There was a problem hiding this comment.
intentional delete?
Member
Author
There was a problem hiding this comment.
yeah unnecessar test imo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds instrumentation for the mistral SDK (
@mistralai/mistralai):Notes: