Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions js/src/exports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export {
SpanImpl,
TestBackgroundLogger,
_exportsForTestingOnly,
_experimental,
_internalGetGlobalState,
_internalSetInitialState,
constructLogs3OverflowRequest,
Expand Down
121 changes: 121 additions & 0 deletions js/src/logger.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
import { vi, expect, test, describe, beforeEach, afterEach } from "vitest";
import {
_exportsForTestingOnly,
_experimental,
init,
initLogger,
Prompt,
BraintrustState,
currentLogger,
loadPrompt,
loadParameters,
wrapTraced,
Expand Down Expand Up @@ -1396,6 +1398,125 @@ describe("wrapTraced generator support", () => {
});
});

describe("_experimental.withConfig", () => {
beforeEach(() => {
_exportsForTestingOnly.simulateLogoutForTests();
});

test("scopes logger selection and restores existing current logger", () => {
const baseLogger = initLogger({
projectName: "base-project",
projectId: "base-project-id",
});
expect(currentLogger()).toBe(baseLogger);

_experimental.withConfig({ project: "scoped-project" }, () => {
const scopedLogger = currentLogger();
expect(scopedLogger).toBeDefined();
expect(scopedLogger).not.toBe(baseLogger);
});

expect(currentLogger()).toBe(baseLogger);
});

test("maintains scoped logger across async boundaries", async () => {
const baseLogger = initLogger({
projectName: "base-project",
projectId: "base-project-id",
});
let scopedLogger: ReturnType<typeof currentLogger> | undefined;

await _experimental.withConfig({ project: "async-project" }, async () => {
await Promise.resolve();
scopedLogger = currentLogger();
await new Promise((resolve) => setTimeout(resolve, 0));
expect(currentLogger()).toBe(scopedLogger);
});

expect(scopedLogger).toBeDefined();
expect(currentLogger()).toBe(baseLogger);
});

test("nested calls reuse scoped logger and apply inner project config", () => {
initLogger({
projectName: "base-project",
projectId: "base-project-id",
});

let outerLogger: ReturnType<typeof currentLogger> | undefined;
let innerLogger: ReturnType<typeof currentLogger> | undefined;

_experimental.withConfig({ project: "outer-project" }, () => {
outerLogger = currentLogger();
const outerSpan = startSpan({ name: "outer-project-span" });
expect(outerSpan.getParentInfo()?.computeObjectMetadataArgs).toEqual({
project_name: "outer-project",
});
outerSpan.end();

_experimental.withConfig({ project: "inner-project" }, () => {
innerLogger = currentLogger();
expect(innerLogger).toBeDefined();
expect(innerLogger).toBe(outerLogger);
const innerSpan = startSpan({ name: "inner-project-span" });
expect(innerSpan.getParentInfo()?.computeObjectMetadataArgs).toEqual({
project_name: "inner-project",
});
innerSpan.end();
});

const outerSpanAfterInner = startSpan({ name: "outer-project-span-2" });
expect(
outerSpanAfterInner.getParentInfo()?.computeObjectMetadataArgs,
).toEqual({
project_name: "outer-project",
});
outerSpanAfterInner.end();

expect(currentLogger()).toBe(outerLogger);
});
});

test("top-level scopes reuse cached experimental logger instance", () => {
initLogger({
projectName: "base-project",
projectId: "base-project-id",
});

let firstLogger: ReturnType<typeof currentLogger> | undefined;
let secondLogger: ReturnType<typeof currentLogger> | undefined;

_experimental.withConfig({ project: "project-one" }, () => {
firstLogger = currentLogger();
const span = startSpan({ name: "project-one-span" });
expect(span.getParentInfo()?.computeObjectMetadataArgs).toEqual({
project_name: "project-one",
});
span.end();
});

_experimental.withConfig({ project: "project-two" }, () => {
secondLogger = currentLogger();
const span = startSpan({ name: "project-two-span" });
expect(span.getParentInfo()?.computeObjectMetadataArgs).toEqual({
project_name: "project-two",
});
span.end();
});

expect(firstLogger).toBeDefined();
expect(secondLogger).toBe(firstLogger);
});

test("requires a non-empty project name", () => {
expect(() =>
_experimental.withConfig({ project: " " }, () => {}),
).toThrow(
"withConfig requires a non-empty project name in `configuration.project`",
);
});
});

describe("parent precedence", () => {
let memory: any;

Expand Down
Loading
Loading