Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/dev/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export type ParametersContainer = z.infer<typeof parametersContainerSchema>;
const staticParametersContainerSchema = z.object({
type: z.literal("braintrust.staticParameters"),
schema: staticParametersSchema,
source: z.null(),
source: z.null().nullish(),
});

export type StaticParametersContainer = z.infer<
Expand Down
28 changes: 28 additions & 0 deletions js/src/zod/zod-v3-serialization.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
serializeEvalParametersToStaticParametersSchema,
serializeRemoteEvalParametersContainer,
} from "../framework2";
import { serializedParametersContainerSchema } from "../../dev/types";
// Detect which zod version is installed by checking for v4-specific properties
function getInstalledZodVersion(): 3 | 4 {
const testSchema = zodModule.z.string();
Expand Down Expand Up @@ -171,3 +172,30 @@ describe("serializeRemoteEvalParametersContainer with Zod v3", () => {
}
});
});

describe("serializedParametersContainerSchema parsing", () => {
const schema = {
model: {
type: "model" as const,
description: "Model to use",
default: "gpt-5-mini",
},
};

test("parses braintrust.staticParameters with source: null", () => {
const result = serializedParametersContainerSchema.safeParse({
type: "braintrust.staticParameters",
schema,
source: null,
});
expect(result.success).toBe(true);
});

test("parses braintrust.staticParameters with source omitted", () => {
const result = serializedParametersContainerSchema.safeParse({
type: "braintrust.staticParameters",
schema,
});
expect(result.success).toBe(true);
});
});
Loading