test(google_genai): migrate golden coverage to vcr tests#196
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Open
test(google_genai): migrate golden coverage to vcr tests#196Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Conversation
Move the remaining Google GenAI scenarios that were only exercised by the manual golden suite into the integration test module with recorded VCR cassettes. The new coverage focuses on image and document inputs, prefill, short max-token truncation, tool-result follow-ups, and reasoning metrics while avoiding duplicate tests for flows already covered in the integration suite. Remove the now-redundant genai golden suite and trim the golden README so it only describes the remaining suites.
Abhijeet Prasad (AbhiPrasad)
requested a review
from ViaDézo1er / cedric (viadezo1er)
|
Drop into this review session: No serious bugs or issues found 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #140
Move the remaining Google GenAI scenarios that were only exercised by the manual golden suite into the integration test module with recorded VCR cassettes.
The new coverage focuses on image and document inputs, prefill, short max-token truncation, tool-result follow-ups, and reasoning metrics while avoiding duplicate tests for flows already covered in the integration suite.
Remove the now-redundant genai golden suite and trim the golden README so it only describes the remaining suites.