feat(langsmith)!: migrate wrapper to integration#204
Closed
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Closed
feat(langsmith)!: migrate wrapper to integration#204Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Conversation
Move the LangSmith instrumentation into braintrust.integrations.langsmith and reduce the legacy wrapper to a setup_langsmith compatibility shim. Add LangSmith to auto_instrument, add a dedicated nox session, and cover the patched traceable and evaluate surfaces with VCR-backed tests plus an auto-test script. BREAKING CHANGE: remove the public LangSmith helper exports wrap_traceable, wrap_client, wrap_evaluate, wrap_aevaluate, get_braintrust_results, and clear_braintrust_results from both braintrust.integrations.langsmith and braintrust.wrappers.langsmith_wrapper. The compatibility wrapper now exposes setup_langsmith only.
|
Drop into this review session: Found 2 issues:
braintrust-sdk-python/py/examples/langsmith/eval_example.py Lines 22 to 24 in 8c9d4a6 braintrust-sdk-python/py/examples/langsmith/tracing_example.py Lines 21 to 23 in 8c9d4a6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the LangSmith instrumentation into
braintrust.integrations.langsmithand reduce the legacy wrapper to asetup_langsmithcompatibility shim.Add LangSmith to
auto_instrument, add a dedicated nox session, and cover the patched traceable and evaluate surfaces with VCR-backed tests plus an auto-test script.BREAKING CHANGE: remove the public LangSmith helper exports
wrap_traceable,wrap_client,wrap_evaluate, andwrap_aevaluatefrom bothbraintrust.integrations.langsmithandbraintrust.wrappers.langsmith_wrapper. The compatibility wrapper now exposessetup_langsmithonly.This breaking change is needed to ensure we can properly do the migration. We don't document
wrap_traceable,wrap_client,wrap_evaluate, andwrap_aevaluateanywhere so we can easily do this.