fix(anthropic): move ephemeral cache creation fields to metadata#205
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Open
fix(anthropic): move ephemeral cache creation fields to metadata#205Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Conversation
The ephemeral cache creation breakdown fields (ephemeral_5m_input_tokens, ephemeral_1h_input_tokens) were being recorded as metrics, which required adding them to the standard metrics allowlists. Move them to span metadata instead, since they are informational breakdowns of the already-tracked prompt_cache_creation_tokens metric. This fixes the CI failure in test_standard_metrics_crawl where the integration tests reject unrecognized standard metric names.
|
Drop into this review session: No serious bugs or issues found 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ephemeral cache creation breakdown fields
(ephemeral_5m_input_tokens, ephemeral_1h_input_tokens) were being
recorded as metrics, which required adding them to the standard
metrics allowlists. Move them to span metadata instead, since they
are informational breakdowns of the already-tracked
prompt_cache_creation_tokens metric.