feat(openai): migrate openai wrapper and add claude agent sdk integration#206
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit intomainfrom
Open
Conversation
a12f43b to
50dae47
Compare
|
Drop into this review session: Found 3 issues:
Compare with the working pattern:
braintrust-sdk-python/py/src/braintrust/integrations/__init__.py Lines 1 to 26 in 50dae47
braintrust-sdk-python/py/src/braintrust/oai.py Line 1107 in 50dae47 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
62144a7 to
4069970
Compare
…tion Move OpenAI wrapper tests, cassettes, and tracing code from `wrappers/` into `integrations/openai/`. Split OpenAI Agents SDK tracing processor into its own `integrations/openai_agents/` package with a dedicated `test_openai_agents` nox session. Add new Claude Agent SDK integration under `integrations/` with subprocess transport-level cassette support. The old `wrappers/openai.py` now re-exports `BraintrustTracingProcessor` from the new location for backward compatibility. Test paths in `noxfile.py` are updated to point at the new integration directories.
4069970 to
948dcd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move OpenAI wrapper tests, cassettes, and tracing code from
wrappers/intointegrations/openai/. Split OpenAI Agents SDK tracing processor into its ownintegrations/openai_agents/package with a dedicatedtest_openai_agentsnox session.Add new Claude Agent SDK integration under
integrations/with subprocess transport-level cassette support.The old
wrappers/openai.pynow re-exportsBraintrustTracingProcessorfrom the new location for backward compatibility. Test paths innoxfile.pyare updated to point at the new integration directories.