Fix parallel tool call input bugs#166
Merged
Ken Jiang (knjiang) merged 5 commits intomainfrom Apr 1, 2026
Merged
Conversation
bcd28fc to
30a5404
Compare
Ankur Goyal (ankrgyl)
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR can be reviewed commit by commit. https://linear.app/braintrustdata/issue/BT-4573/fix-parallel-tools-google-adk-bug-with-anthropic-openai
failures look like:
{ "error": "400 An assistant message with 'tool_calls' must be followed by tool messages responding to each 'tool_call_id'. The following tool_call_ids did not have response messages: toolu_nyc", "name": "Error" }First commit:
make capturewhich does two things:a. snapshots the LLM request/responses for the
parallelToolCallsRequestb. runs
transform_requestlogic by swapping out models for a different provider to "simulate" LLM transforms.transform_errors.jsonwhich lets CI pass. the CI fails when there are undocumented bugs.Second commit:
transform_errors.jsontransform_errors.jsonwhile maintaining lingua best practicescrates/lingua, I ranmake regenerate-failed-transformsa.
make regenerate-failed-transformsonly runs the capture script on transforms that have materially changed based on the snapshots in https://github.com/braintrustdata/lingua/blob/main/payloads/scripts/transforms/__snapshots__/transforms.test.ts.snap