feat: Add nba_api issue #602 validation notebook #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add validation notebook confirming BoxScoreTraditionalV3 normalized methods bug - Test get_normalized_dict() and get_normalized_json() for V3 endpoints - Demonstrate that both methods return empty values (issue exists) - Include comparison with working methods (get_dict, get_json, get_data_frames) - Update README with issue #602 as confirmed bug Validation proves issue #602 is a real bug affecting V3 endpoints. After fix in nba_api PR #606, this notebook will show the issue is resolved. Related: swar/nba_api#602 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds validation notebook for nba_api issue #602 proving that
get_normalized_dict()andget_normalized_json()return empty values for BoxScoreTraditionalV3.Changes
nba_api_issue_validations/issue_602_boxscore_normalized_methods.ipynbIssue Status
Confirmed Bug - The validation proves that:
get_normalized_dict()returns empty dictionary{}get_normalized_json()returns empty JSON"{}"get_dict(),get_json(),get_data_frames()) work correctlyFix Status
I've created a PR to fix this issue in the nba_api repository:
Once merged, this validation notebook will demonstrate that the issue is resolved.
Run the Validation
Click Runtime → Run all to execute the validation.
🤖 Generated with Claude Code