Fix Windows test isolation and cleanup#3
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PI_SCRAPER_STORAGE_ROOTinstead ofHOME, including both tool-smoke suitescloseStorageDbs()before deleting temporary roots and add missing closes in crawl/result testsWhy
On Windows,
node:os.homedir()ignores test-onlyHOMEoverrides, so smoke and storage tests could write under the real user profile. Several teardowns also started the asynchronous database close without awaiting it, then immediately deleted SQLite/WAL files, causingEBUSYfailures.Impact
Test storage is now isolated to per-test temporary roots, SQLite handles are closed before cleanup, and Windows CI covers the same full suite used on Linux. Production runtime behavior is unchanged.
Validation
bun run teston Windows: 105 files passed; 916 tests passed, 5 intentionally skippedbun run typecheckbun run lint(passes; existing warnings remain)bun run format:checkbun run test:selection: 16/16bun run test:tools: 7/7bun run lint:workflowsgit diff --check