feat(events): expose user_agent and client_ip in /v1/events#5
Merged
Conversation
Both fields are already accepted on ingest and stored in the label table (LABEL_CLIENT_IP=3, LABEL_USER_AGENT=4) — they survive the event roundtrip into LlmEvent. This change just plumbs them through the read path so /v1/events consumers can derive SDK / geographic breakdowns without re-querying the raw event row. - EventSummary (keplor-store/types.rs) gains client_ip + user_agent. - llm_to_summary copies them from the underlying LlmEvent. - EventResponse (keplor-server/routes.rs) gains the same two fields, serialized with skip_serializing_if = Option::is_none so events without recorded IP/UA stay compact on the wire. - export_events and the s3 archive-merge path mirror the change. No schema change. No new column read on the hot path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both fields are already accepted on ingest and stored in the label table (`LABEL_CLIENT_IP=3`, `LABEL_USER_AGENT=4`) — they survive the event roundtrip into `LlmEvent`. This change just plumbs them through the read path so `/v1/events` consumers can derive SDK / geographic breakdowns without re-querying the raw event row.
No schema change. No new column read on the hot path.
This unblocks Obol PR (forthcoming) that adds SDK + geographic widgets to `/monitor`.
Test plan