feat(blocks): support heading 4/5/6 blocks#73
Merged
Conversation
Add concrete block classes for Notion heading_4, heading_5, and heading_6 payloads so the existing heading hydration path preserves rich text for higher heading levels. Extend block tests to cover class resolution, serialization fields, and unsupported block fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add concrete block models for Notion
heading_4,heading_5, andheading_6payloads.The new classes reuse the existing generic heading hydration and serialization path, so higher heading levels now preserve rich text instead of resolving to
UnsupportedBlock.Motivation and context
Notion can return higher heading levels. Without matching block classes, those payloads fall back to
UnsupportedBlock, which does not hydrate the heading property and loses rich text for consumers.How has this been tested?
composer testcomposer dev:lint:syntaxcomposer dev:lint:stylecomposer dev:analyze:allTypes of changes
PR checklist