Skip to content

Preserve mobile header navigation - #10

Merged
brenosampaio-dev merged 1 commit into
mainfrom
agent/refine-mobile-cv-header
Jul 25, 2026
Merged

Preserve mobile header navigation#10
brenosampaio-dev merged 1 commit into
mainfrom
agent/refine-mobile-cv-header

Conversation

@brenosampaio-dev

Copy link
Copy Markdown
Owner

What changed

  • tightens mobile dock spacing without changing its visual language
  • keeps both Work and About visible on standard 390px phones
  • only hides About on exceptionally narrow screens at 340px and below
  • preserves the compact CV download action and prevents horizontal overflow

Validation

  • npm run lint
  • npm run build
  • browser checks at 390px and 320px
  • body width matches viewport at both breakpoints
  • header retains comfortable side margins

@vercel

vercel Bot commented Jul 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portfolio Ready Ready Preview, Comment Jul 25, 2026 3:03pm

@brenosampaio-dev
brenosampaio-dev marked this pull request as ready for review July 25, 2026 15:04
@brenosampaio-dev
brenosampaio-dev merged commit a00a68f into main Jul 25, 2026
6 checks passed
@brenosampaio-dev
brenosampaio-dev deleted the agent/refine-mobile-cv-header branch July 25, 2026 15:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 146a2aa16e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

padding-inline: var(--space-2);
gap: 10px;
}
.nav a[href="/#about"] { display: none; }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep About hidden until the full dock fits

At viewport widths just above 340px, this rule immediately restores About even though the centered, non-wrapping dock still contains the wordmark, Work/About links, Contact, CV action, dividers, and theme control. Its intrinsic width exceeds these narrow viewports, so the dock's ends are clipped or create horizontal overflow; the checks at 320px and 390px miss this discontinuity. Move the breakpoint to the width at which the complete dock actually fits, or constrain the dock responsively.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant