Skip to content

Ensure capacity before pinning span. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brian-reichle merged 1 commit into from
Jun 8, 2025
Merged

Ensure capacity before pinning span. #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/TextTools/StringBuilderSpanExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ public static StringBuilder Append(this StringBuilder builder, ReadOnlySpan<char
#if NET || NETSTANDARD2_1_OR_GREATER
return builder.Append(span);
#else
// Ensure there will be enough capacity for the span before pinning,
// to reduce the risk of triggering a GC while span is pinned.
builder.EnsureCapacity(builder.Length + span.Length);

unsafe
{
fixed (char* ptr = span)
Expand Down