alternative currencies were previously supported... weren't they?

I had the configuration working fine, upgraded to latest and now I can't view my sensors in CAD currency. This suggests to me that the only thing preventing alternative currencies is a check in the python of this plugin? Can you add support for additional currencies?
https://github.com/brianberg/ha-nicehash/blob/master/custom_components/nicehash/sensor.py#L124

Am I crazy to think it worked before? I checked the history on the code and didn't see any recent changes to it...

Version of the custom_component

72543f6

Configuration

nicehash:
  organization_id: !secret nicehash_id
  api_key: !secret nicehash_key
  api_secret: !secret nicehash_secret
  currency: CAD # (default = USD)
  balances: true # (default = false) - Enable balance sensors
  rigs: true # (default = false) - Enable rig sensors
  devices: false # (default = false) - Enable device sensors
  payouts: false # (default = false) - Enable payout sensors

Describe the bug

Should be able to support any currency that nicehash also supports.

Debug log


Logger: custom_components.nicehash.sensor
Source: custom_components/nicehash/sensor.py:151
Integration: NiceHash (documentation, issues)
First occurred: 10:48:29 (1 occurrences)
Last logged: 10:48:29

Invalid currency: must be EUR or USD

Nicehash does not have a BTC-CAD exchange rate in the list of rates from the API route I am using. I don't know if it was there previously, but currently it is not.

Without a direct exchange rate, I'm not sure how best to convert BTC to CAD.

https://api2.nicehash.com/main/api/v2/exchangeRate/list

Understood. Thanks anyway.

Hmm... They do have a usd to cad. Would it be possible as an extra step to do the conversion from BTC to usd to cad?

Converting BTC -> USD -> CAD would be possible and makes sense to me. I'd imagine there will be a trivial amount lost during the conversion but should be sufficient for now

Does NiceHash display funds in CAD on the website?

They have a setting in your account to select the currency displayed everywhere. Apps/web included.

I also using IDR and it's supported by nicehash web/program, when i tried to use IDR i think it give me back BTC

Nicehash also supports GBP, I'd love to be able to see that in the Home Assistant integration

Converting BTC -> USD -> CAD would be possible and makes sense to me. I'd imagine there will be a trivial amount lost during the conversion but should be sufficient for now

I submitted pull request #24 that does exactly this.

Navigation Menu

Repository navigation

alternative currencies were previously supported... weren't they? #3

Version of the custom_component

Configuration

Describe the bug

Debug log

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

alternative currencies were previously supported... weren't they? #3

Description

Version of the custom_component

Configuration

Describe the bug

Debug log

Activity

brianberg commented on Apr 1, 2021

pironic commented on Apr 1, 2021

pironic commented on Apr 1, 2021

brianberg commented on Apr 5, 2021

brianberg commented on Apr 5, 2021

pironic commented on Apr 5, 2021

Bios-dude commented on Apr 12, 2021

Vitani commented on May 10, 2021

cathaloc commented on May 16, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions