-
Notifications
You must be signed in to change notification settings - Fork 12
Add fhirpath.zig WASM engine support (R4 + R5) #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jmandel
wants to merge
8
commits into
brianpos:master
Choose a base branch
from
jmandel:add-fhirpath-zig-engine
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3ed5bd4
Add fhirpath.zig WASM engine support (R4 + R5)
jmandel 97f5b85
Enable XML support for fhirpath.zig engine
jmandel 7d01d7d
Fix XML context handling: track format per context entry
jmandel a77e7ae
Prefer isXmlResource flag over content sniffing for XML detection
jmandel 6b20f44
Use isXmlResource flag directly, drop content sniffing
jmandel d2f71ce
Update to new fhirpath.zig API (options object pattern)
jmandel 2f86aff
Drop redundant wasmUrl (defaults via import.meta.url)
jmandel 6f9e904
Drop explicit schema URLs (defaults via import.meta.url)
jmandel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue here is the reason why the PR hasn't been merged in.
I'd prefer this engine to be hooked in via a node hosted service similar to https://github.com/brianpos/fhirpath-lab-fhirpath-js-api.
This then
Currently the fhirpath.js engine is the only one that is "local" to the browser, even though others could be done that way.
This removes the burden of updates, or random external js loading and execution in the platform.
Though it does cost in terms of requiring a hosted service to call.
I have also introduced a mechanism to be able to tag them as only visible with "show advanced properties" is on (for less common/more advanced things) and also a new feature for enabling custom engine URLs via URL parameter.