Simplify core vs std usage#836
Merged
briansmith merged 1 commit intobriansmith:masterfrom Jun 13, 2019
Merged
Conversation
briansmith
approved these changes
Jun 13, 2019
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now,
src/lib.rsdefines ring to be ano_stdcrate conditionally based on the features and CPU architecture. This is sub-optimal, as it requires a lot ofcfgattributes to be kept in sync. Bothrandandrdrandhave dealt with this kind of problem, and they use the following solution.#![no_std]stdis needed, it can be brought in withextern crate stduse stdoruse corestatements (as they are never necessary)This is what I did in this PR. Some advantages to this PR:
std. This helps with:no_std-only platform #744no_stdextern crate alloclands in the next stable Rust release, most of theuse std::statements can be turned intouse alloc::.use_heapfeature into two featuresstd: Enables getting randomness from files andstd::error::Errorimplementationsalloc: Enables operations that need dynamic memory allocation (RSA signing, etc...)