Remove deprecated Error::description and Error::cause#933
Closed
AnderEnder wants to merge 1 commit intobriansmith:masterfrom
Closed
Remove deprecated Error::description and Error::cause#933AnderEnder wants to merge 1 commit intobriansmith:masterfrom
AnderEnder wants to merge 1 commit intobriansmith:masterfrom
Conversation
briansmith
requested changes
Jan 20, 2020
Owner
briansmith
left a comment
briansmith
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Will this affect the minimum supported Rust version? I.e. is this a breaking change at all?
| impl KeyRejected { | ||
| /// The value returned from <Self as std::error::Error>::description() | ||
| /// The value is used in Display | ||
| pub fn description_(&self) -> &'static str { |
Owner
There was a problem hiding this comment.
Again, I think description_() should be removed; its code should be inlined into the Display implementation.
| } | ||
|
|
||
| fn description(&self) -> &str { | ||
| Self::description_() |
Owner
There was a problem hiding this comment.
description_() should be removed and inlined into the Display implementation.
Owner
|
@AnderEnder Thanks for the PR. I created a new PR that implements the changes I requested: #938, so I'm going to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error::descriptionhas been documented as soft-deprecated since 1.27.0 (17 months ago). It is going to be hard-deprecated soon.Error::causehas been documented as deprecated since 1.33.0.This PR:
descriptionandcausein all error typesRelated PR: rust-lang/rust#66919