fix: dynamic version test + upgrade setup-node to v4#1
Merged
Conversation
- Read version from package.json in test instead of hardcoding v0.1.0 - This was causing all CI to fail after version bumps (tests → release → publish) - Upgrade actions/setup-node from v3 to v4 (Node.js 20 deprecation warning)
nmccready
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All CI pipelines (release, publish) are failing because the version test in
sync-agents.batshardcodesv0.1.0:After
commit-and-tag-versionbumped to0.1.1, the test breaks → tests fail → release skipped → publish never runs.Fix
Dynamic version in test — Read version from
package.jsonat test time instead of hardcoding it. The test will now survive all future version bumps.Upgrade
actions/setup-nodev3 → v4 — Node.js 20 actions are deprecated (forced to Node 24 starting June 2026). Fixes the deprecation warnings in CI.Changes
test/sync-agents.bats: ExtractPACKAGE_VERSIONfrompackage.json, use in--versiontest.github/workflows/tests.yml:setup-node@v3→setup-node@v4.github/workflows/commitlint.yml:setup-node@v3→setup-node@v4Testing
All 38 tests pass locally ✅