Docs/expired account recovery runbook - #445
Merged
phertyameen merged 5 commits intoJul 28, 2026
Merged
Conversation
|
@mijinummi Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary & Key Changes
This PR establishes the
bridgelet-audit/directory with operational runbooks and threat models covering contract trust boundaries, administrative privileges, token handling assumptions, and recovery procedures.Closes #277
Closes #280
Closes #276
Closes #274
1. 📖 Operational Runbook: Stuck/Expired Account Recovery — Closes #280
bridgelet-audit/runbooks/stuck-expired-account-recovery.mdis_expired()andget_status()prior to taking recovery actions.expire()vs. restrictedrecover()(creator/recovery address) invocation conditions.reclaim_reserve()and noted its idempotent safety guarantees.2. 🗺️ Threat Model: Cross-Contract Trust Boundaries — Closes #274
bridgelet-audit/threat-models/cross-contract-trust-boundaries.mdAccountFactory,SweepController,EphemeralAccount, and standard token contracts.3. 🛡️ Threat Model: Upgrade & Admin Authority — Closes #276
bridgelet-audit/threat-models/upgrade-admin-authority.mdEphemeralAccountContract::upgrade()andReserveContract::set_base_reserve().AccountFactoryandSweepController.4. 🪙 Threat Model: Token Transfer Trust Assumptions — Closes #277
bridgelet-audit/threat-models/token-transfer-trust-assumptions.mdpayment.assetcompliance with SEP-41 / Soroban Asset Contract standards inexecute_transfers.docs/reentrancy-analysis.md.📁 Files Added
bridgelet-audit/runbooks/stuck-expired-account-recovery.mdbridgelet-audit/threat-models/cross-contract-trust-boundaries.mdbridgelet-audit/threat-models/upgrade-admin-authority.mdbridgelet-audit/threat-models/token-transfer-trust-assumptions.md✅ Checklist
bridgelet-audit/