Skip to content

Feat/sweep - #447

Merged
phertyameen merged 2 commits into
bridgelet-org:mainfrom
ummarig:feat/sweep
Jul 28, 2026
Merged

Feat/sweep#447
phertyameen merged 2 commits into
bridgelet-org:mainfrom
ummarig:feat/sweep

Conversation

@ummarig

@ummarig ummarig commented Jul 28, 2026

Copy link
Copy Markdown

Summary of Changes:

  1. Tabulated precondition checks: Created a clear comparison table showing all precondition checks performed by both entrypoints, highlighting the key differences
  2. Explained intended callers: Clearly stated that each entrypoint is exclusively invoked by its corresponding SweepController method (execute_sweep() for sweep(), claim() for sweep_claim())
  3. Documented execution flows: Provided detailed step-by-step flows for both the off-chain-signed flow and the native-auth claim flow
  4. Verified shared outcomes: Explicitly stated that both entrypoints produce identical state transitions and reserve-reclaim behavior, listing the exact shared final logic they execute

closes #265

The file now accurately documents the two sweep entrypoints in EphemeralAccountContract, fulfilling all the requirements specified in the issue. The documentation is contained entirely within the bridgelet-audit/glossary directory as requested, with no changes needed to any other parts of the codebase.

closes #259

Summary of what was implemented:

  1. Created the new file: bridgelet-audit/glossary/checks-effects-interactions.md - a standalone documentation file as requested
  2. Described the CEI pattern: Explained the three phases (Checks, Effects, Interactions) and how it prevents reentrancy attacks
  3. Pointed to sweep() implementation: Showcased the exact code from EphemeralAccountContract::sweep() that implements the pattern, highlighting that state.set_status(Swept) happens before any external interactions
  4. Cross-referenced reentrancy analysis: Included a link to docs/reentrancy-analysis.md as the canonical source for full reasoning

closes #258

  1. Covered both entrypoints: Mentioned that sweep_claim() follows the same secure pattern for consistency

The file fulfills all the requirements: it's documentation-only, lives in the correct bridgelet-audit/glossary directory, and explains how the CEI pattern is applied in the sweep() function. No changes were made to contracts/, docs/, scripts/, or tools/ as requested.

closes #257

@drips-wave

drips-wave Bot commented Jul 28, 2026

Copy link
Copy Markdown

@ummarig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@phertyameen
phertyameen merged commit 82f7dda into bridgelet-org:main Jul 28, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment