Feat/sweep - #447
Merged
Merged
Conversation
|
@ummarig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
execute_sweep()forsweep(),claim()forsweep_claim())closes #265
The file now accurately documents the two sweep entrypoints in EphemeralAccountContract, fulfilling all the requirements specified in the issue. The documentation is contained entirely within the bridgelet-audit/glossary directory as requested, with no changes needed to any other parts of the codebase.
closes #259
Summary of what was implemented:
bridgelet-audit/glossary/checks-effects-interactions.md- a standalone documentation file as requestedEphemeralAccountContract::sweep()that implements the pattern, highlighting thatstate.set_status(Swept)happens before any external interactionsdocs/reentrancy-analysis.mdas the canonical source for full reasoningcloses #258
sweep_claim()follows the same secure pattern for consistencyThe file fulfills all the requirements: it's documentation-only, lives in the correct bridgelet-audit/glossary directory, and explains how the CEI pattern is applied in the sweep() function. No changes were made to contracts/, docs/, scripts/, or tools/ as requested.
closes #257