Skip to content

Feat/build - #448

Merged
phertyameen merged 2 commits into
bridgelet-org:mainfrom
nafsonig:feat/build
Jul 28, 2026
Merged

Feat/build#448
phertyameen merged 2 commits into
bridgelet-org:mainfrom
nafsonig:feat/build

Conversation

@nafsonig

Copy link
Copy Markdown
Contributor
  1. Explanation of the target: It clearly describes what wasm32v1-none is as a Soroban-specific WASM target, and how it differs from the generic wasm32-unknown-unknown target, including the critical feature compatibility issue that led to its adoption.

  2. All references in the repository: I've listed every place the target is used, including:

    • CI workflow configurations in .github/workflows/test.yml with exact line numbers and code snippets
    • Artifact upload paths in the same workflow file
    • Documentation in scripts/build.sh that explains the rationale for using this target
    • All test files and runbooks that reference the target string

closes #268

  1. Scope note: The file includes a clear statement that this is purely descriptive and does not propose any build configuration changes, as required.

The glossary entry follows the same pattern as the existing entries in the bridgelet-audit/glossary/ directory and meets all the requirements specified in the issue.

  1. Definition of a salt: Explains what a salt is in the context of batch_initialize's deploy_v2 calls, and how it's used in Soroban's deterministic address derivation.

closes #266

  1. Salt derivation explanation: Details how the current implementation combines a monotonic factory-wide batch nonce with the request's position (index) in the batch to create unique salts, including the exact byte layout and code snippet from the implementation.

  2. Uniqueness properties: Describes all the critical uniqueness properties salts must have across the contract's entire lifetime, including global uniqueness, batch isolation, within-batch uniqueness, and overflow prevention.

closes #264

  1. CREATE2-style deployment reference: Links the salt mechanism to the broader CREATE2-style deployment pattern, explaining how it implements those core concepts within Soroban's runtime, while noting that a separate create2-style-deployment.md entry doesn't currently exist in the repository.

The file is purely documentation as requested, follows the same pattern as existing glossary entries, and makes no changes to any code or other functional files in the repository.

closes #256

@drips-wave

drips-wave Bot commented Jul 28, 2026

Copy link
Copy Markdown

@nafsonig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@phertyameen
phertyameen merged commit 4467e38 into bridgelet-org:main Jul 28, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment