Feat/build - #448
Merged
Merged
Conversation
|
@nafsonig Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of the target: It clearly describes what
wasm32v1-noneis as a Soroban-specific WASM target, and how it differs from the genericwasm32-unknown-unknowntarget, including the critical feature compatibility issue that led to its adoption.All references in the repository: I've listed every place the target is used, including:
.github/workflows/test.ymlwith exact line numbers and code snippetsscripts/build.shthat explains the rationale for using this targetcloses #268
The glossary entry follows the same pattern as the existing entries in the
bridgelet-audit/glossary/directory and meets all the requirements specified in the issue.batch_initialize'sdeploy_v2calls, and how it's used in Soroban's deterministic address derivation.closes #266
Salt derivation explanation: Details how the current implementation combines a monotonic factory-wide batch nonce with the request's position (index) in the batch to create unique salts, including the exact byte layout and code snippet from the implementation.
Uniqueness properties: Describes all the critical uniqueness properties salts must have across the contract's entire lifetime, including global uniqueness, batch isolation, within-batch uniqueness, and overflow prevention.
closes #264
create2-style-deployment.mdentry doesn't currently exist in the repository.The file is purely documentation as requested, follows the same pattern as existing glossary entries, and makes no changes to any code or other functional files in the repository.
closes #256