This repository was archived by the owner on Jun 1, 2022. It is now read-only.
Open
Conversation
…r workers created by controller) Signed-off-by: Valery Masiutsin <val.masutin@gmail.com>
vdice
reviewed
Jun 29, 2020
Contributor
vdice
left a comment
vdice
left a comment
There was a problem hiding this comment.
A few minor suggestions on value placement and one typo area. Otherwise looking great!
Signed-off-by: Valery Masiutsin <val.masutin@gmail.com>
vmasutin
force-pushed
the
affinities-support
branch
from
19577a7 to
410af89
Compare
Signed-off-by: Valery Masiutsin <val.masutin@gmail.com>
vdice
reviewed
Jul 1, 2020
Contributor
vdice
left a comment
vdice
left a comment
There was a problem hiding this comment.
One more item when convenient...
…dice Signed-off-by: Valery Masiutsin <val.masutin@gmail.com>
Contributor
|
/brig run |
vdice
reviewed
Jul 1, 2020
Contributor
vdice
left a comment
vdice
left a comment
There was a problem hiding this comment.
Last round of suggested changes -- apologies. I finally got around to testing this on a Brigade instance in conjunction with the changes in brigadecore/brigade#1095.
Signed-off-by: Valery Masiutsin <val.masutin@gmail.com>
…onding charts as suggested by vdice Signed-off-by: Valery Masiutsin <val.masutin@gmail.com>
Contributor
|
/brig run |
vdice
approved these changes
Jul 2, 2020
Contributor
vdice
left a comment
vdice
left a comment
There was a problem hiding this comment.
LGTM! We may want to wait to merge pending naming decisions in brigadecore/brigade#109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding affinity support to the brigade helm charts(both for deploying brigade components and for workers created by controller)
Please see Brigade PR for more details