feat: write database_dependencies to datapackage metadata (v4.7)#265
Merged
Conversation
Add dp.metadata["database_dependencies"] = sorted(dependents) in Database.process() before finalize_serialization(), so the datapackage itself carries the list of databases it depends on. The dependents set is already computed during exchange iteration; this just surfaces it into the datapackage file alongside the existing self.metadata["depends"]. Add migration "4.7 database dependencies in datapackage" that reprocesses all databases so existing datapackages gain the new metadata field. Bump version to 4.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Database.process()now writesdp.metadata["database_dependencies"] = sorted(dependents)into the datapackage beforefinalize_serialization(), so downstream consumers can inspect which databases a datapackage depends on without re-scanning exchangesdependentsset is already computed during exchange iteration — this change only surfaces it into the datapackage file (the existingself.metadata["depends"]entry is unchanged)"4.7 database dependencies in datapackage"reprocesses all databases so existing datapackages gain the new field4.7Test plan
test_process_writes_database_dependencies_to_datapackage— writes two databases with a cross-database technosphere exchange and assertspackage.metadata["database_dependencies"] == ["other database"]test_process_writes_empty_database_dependencies_when_no_external_inputs— self-contained database assertspackage.metadata["database_dependencies"] == []