Add memoization cache to get_id() with signal-based invalidation#266
Merged
Conversation
…ninvent by 1 minute.
Caches (database, code) → id lookups in a module-level dict to avoid repeated SQLite queries during large imports (e.g. ecoinvent). Cache is invalidated on project switch, database delete/reset/write, individual activity deletion, and activity code/database changes via blinker signal handlers. Tests cover all invalidation paths. Closes #254
This was referenced May 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_id()for(database, code) → idlookups, avoiding repeated SQLite queries during large imports (reported to save ~1 minute on ecoinvent imports in Adding memoization (cache) to 'get_id()', saves 1 minute per ecoinvent import. #254)functools.lru_cachebecause selective per-database and per-activity invalidation requires__delitem__, whichlru_cachedoes not exposeTest plan
test_get_id_cache_populates— cache is written on first calltest_get_id_cache_returns_same_value— cache hit returns correct valuetest_get_id_cache_project_changed—project_changedclears entire cachetest_get_id_cache_database_delete—on_database_deleteremoves only that database's entriestest_get_id_cache_database_reset—on_database_resetremoves only that database's entriestest_get_id_cache_database_write—on_database_writeremoves only that database's entriestest_get_id_cache_activity_delete—signaleddataset_on_deleteremoves only that activity's entrytest_get_id_cache_activity_code_change—on_activity_code_changeremoves old key, leaves otherstest_get_id_cache_activity_database_change—on_activity_database_changeremoves old key, leaves othersCloses #254