feat: enable installation directly from GitHub via HACS - #1
Conversation
By setting `content_in_root`, we can keep the files in the root directly. The normal HACS format is to have the integration under `custom_components/<integration-name>` https://hacs.xyz/docs/publish/integration/
Summary of ChangesHello @hackmann, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Roth Touchline integration by enabling direct installation through the Home Assistant Community Store (HACS). This is achieved by introducing the necessary HACS configuration file and updating a key dependency, which collectively simplifies the setup process for users and ensures the integration utilizes the latest compatible library version. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enables direct installation from GitHub via HACS by adding a hacs.json file and updating the pytouchline_extended dependency. The changes are appropriate for the stated goal. I have one suggestion to improve the hacs.json file by specifying the minimum required Home Assistant version, which is a recommended practice for HACS integrations to help users with compatibility.
ea3366a to
9f04072
Compare
... this makes it easier to work with the code outside HomeAssistant
By setting
content_in_root, we can keep the files in the root directly. The normal HACS format is to have the integration undercustom_components/<integration-name>https://hacs.xyz/docs/publish/integration/