Repository navigation
chore(deps): bump futures from 0.3.32 to 0.3.34 - #1797
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
4 of 5 tasks
broomva
added a commit
that referenced
this pull request
Oct 4, 2026
…chain drift (BRO-2814) (#1807) * fix(ci): clippy::double_must_use on #[async_trait] traits + stop toolchain drift (BRO-2814) main went red with no code change: every CI job used `dtolnay/rust-toolchain@stable`, which floats to whatever is current stable on the day the job runs. Between the last green run (2026-09-28) and today, `stable` moved 1.93.0 -> 1.99.0 and clippy started treating the boxed `dyn Future` that `#[async_trait]` returns as already `#[must_use]`, so the `#[must_use]` the macro also stamps on the generated method is flagged as `clippy::double_must_use` -- 72 errors in aios-protocol alone, plus the same pattern in 44 more trait definitions across ergon, chronos, haima, life-runtime, etc. This is a known async-trait/clippy interaction, not a real bug in any of these traits, so each site gets a narrow `#[allow(clippy::double_must_use, reason = "...")]` rather than a blanket `-A` on the lint. Also, to close the drift loop itself (not just today's symptom): - Add rust-toolchain.toml pinning channel = "1.99.0" (the toolchain clippy was just made clean against) and switch the CI/harness jobs that used `@stable` to `@master`, which reads that file instead of floating. Bumping the toolchain is now a deliberate edit to this file instead of a silent drift. MSRV Check keeps its own explicit 1.93.0 pin, unchanged. - Add a weekly schedule trigger to ci.yml so main's CI runs even without a push (BRO-2806: main's latest CI must be under 7 days old) -- this is exactly how the drift went undetected for a week. - Group routine cargo minor/patch bumps into one Dependabot PR instead of ten (the ten open PRs #1797-#1806 all failed on this same latent issue, independent of what they bumped). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(ci): pass explicit toolchain to dtolnay/rust-toolchain@master @master requires a `toolchain` input — it does not read rust-toolchain.toml on its own (confirmed by the PR's own CI: every job switched to @master in the previous commit failed in <20s with "'toolchain' is a required input"). Pass toolchain: "1.99.0" explicitly everywhere, matching rust-toolchain.toml's pin; MSRV Check keeps its own "1.93.0". Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(ci): allow clippy::all on two generated-proto modules missing the existing convention CI's Lint job still failed after the previous commit, this time in lago-ingest (3 more double_must_use errors, same async_trait-in- generated-tonic-code root cause as BRO-2814, just inside the include_proto! output this time instead of hand-written source). Every other tonic::include_proto! module in the workspace already carries `#[allow(unused_qualifications, clippy::all)]` (aios-proto, anima/haima/arcan-substrate-proto, life-kernel-proto, ...) specifically because generated code isn't something we hand-tune for clippy. lago-ingest and spaces-a2a were the two that never got it. Bringing them in line with the rest of the codebase, not inventing a new pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * refactor(ci): hoist double_must_use allow to workspace.lints.clippy (BRO-2814) P20 review (strata B+C) on the previous commits flagged that hand-pasting the same #[allow(clippy::double_must_use, reason = "...")] onto 63 trait definitions across 43 files is a maintenance trap: the next #[async_trait] trait anyone adds won't carry it and will silently fail CI again. The repo already has the right mechanism for exactly this (`[workspace.lints.clippy] too_many_arguments = "allow"`, opted into by `[lints] workspace = true` in 41 of the 43 touched crates) -- one line there covers every current AND future #[async_trait] trait workspace-wide, so use it instead of 63 copies of the same 4 lines. arcan-tui and life-cli don't opt into workspace lints yet, so they keep their local #[allow(...)] (now the only two). Verified clean with the real pinned toolchain this time (rustup run 1.99.0 cargo clippy --workspace --all-targets -- -D warnings -A clippy::too_many_arguments), not just the stale local one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Owner
|
@dependabot rebase |
Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.32 to 0.3.34. - [Release notes](https://github.com/rust-lang/futures-rs/releases) - [Changelog](https://github.com/rust-lang/futures-rs/blob/main/CHANGELOG.md) - [Commits](rust-lang/futures-rs@0.3.32...0.3.34) --- updated-dependencies: - dependency-name: futures dependency-version: 0.3.34 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/futures-0.3.34
branch
from
October 4, 2026 14:37
b4af5ed to
9546561
Compare
Contributor
Author
|
Superseded by #1808. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps futures from 0.3.32 to 0.3.34.
Release notes
Sourced from futures's releases.
Changelog
Sourced from futures's changelog.
Commits
705e6b5Release 0.3.34616dac7compat: Inline RawWaker clone function4176369Inline remaining RawWaker clone functionsf17a895Fix cloned FuturesUnordered waker identity51d62admacro: bumpsynto v3 (#3028)9e26177ci: Reduce timeout-minutesb2d0983tsan: Enable Adaptive Delayf733d0eMiri: Ignore compat testse5def2fRename default branch to main89cc254Release 0.3.33