Open
Conversation
Owner
|
Hi @luizvbo , the PR looks good. May I know why you closed it? |
Author
|
Hi @brootware. I am currently using the package in my work and I decided that I need to do bigger changes to the code. Hence, I decided to make a fork of your repo and work from there instead. Few free to apply the PR though. I'm going to reopen it. |
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that there are very long lines in the code, so I set the max-line-lengh to 88 for flake8 and split the long regex strings.
l also added an "r" to the regex strings to avoid the
DeprecationWarning: invalid escape sequencewarning appearing when test_crim.py runs.