Refactor microphone and wake word implementations#78
Merged
Conversation
… word detection and improve separation of Android specific implementations - Simplify VoiceInput, pass Microphone and WakeWord dependencies in constructor and refactor to use a callbackFlow to allow checking for isActive in the audio processing loop to avoid needing to explicitly yield to check for cancellation - Add a WakeWord interface for abstracting wake word detection and add an implementation that wraps the MicroWakeWord implementation to prepare for MicroWakeWord to be extracted to a separate module independent of the ESPHome specific interfaces - Add stubs and tests for VoiceInput
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor VoiceInput, extract interfaces for microphone input and wake word detection and improve separation of Android specific implementations