Rework settings#80
Merged
Merged
Conversation
Owner
brownard
commented
May 16, 2026
brownard
commented
- Refactor settings classes to simplify and reduce duplication
- Save settings using viewModelScope instead of composable scope to prevent cancellation on composition change and simplify UI logic
- Add description support to select settings
- Minor UI tweaks
- Add setting extension function to SettingsStore to simplify creation of SettingStates - Create default implementations of SettingsStores in settings interfaces - Use DataStoreFactory to create the underlying DataStores to remove dependency on a Context - Use encodeTo/decodeFromStream functions when deserialising settings and ignore unknown keys to avoid errors when switching between versions
…oid scope being cancelled during composition changes and simplify the screen logic.
…creen and add settings directly to the screen composable
…ng value and description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.