Add support for configuring microphone source and audio mode#81
Merged
Conversation
- Add AudioProcessingSettings and associated settings screen to allow selecting audio source and mode - Refactor VoiceInput to allow switching microphone source when settings change - Add audio processing documentation and move existing documentation to docs subdirectory
Owner
Author
|
@xvello This pull request adds an 'Audio Processing' settings screen allowing selection of the microphone source and communication/speakerphone mode. These should switch the used source 'on the fly' when changed. Let me know if you think anything should be added/changed, particularly regarding the docs. |
- Use null coalescing to simplify null check - Use more explicit isNotEmpty method instead of checking list length - Make unnecessarily protected field private - Use dictionary indexer instead of get method - Remove unnecessary this tag - Avoid shadowing implicit parameters - Remove unused string resource - Use list instead of array in data class and don't use data class unnecessarily
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to address #48