CJK caption support, Windows fixes, EDL-level style/audio overrides#103
Open
Jerryxumaomao wants to merge 4 commits into
Open
CJK caption support, Windows fixes, EDL-level style/audio overrides#103Jerryxumaomao wants to merge 4 commits into
Jerryxumaomao wants to merge 4 commits into
Conversation
…en by filter parser) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…unking - edl.json 'subtitle_style' overrides SUB_FORCE_STYLE per project - Chinese ASR tokens (per-character) now group into phrase cues: break on CJK punctuation or 10 chars, no inter-char spaces, punctuation-only tokens act as break markers and are never displayed Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ffmpeg's overlay filter crops (not scales) oversized inputs — full-res overlay assets were cropped off-frame on preview/draft renders. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…p ALL punctuation from CJK captions Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four improvements from editing a real Chinese vertical-video (XHS) project with video-use on Windows. Each commit is independent and revertable.
1. fix: Windows subtitle path escaping (413fcf3)
render.pyescaped the drive colon in the subtitles filter path but left raw backslashes, which ffmpeg's filter parser eats (D\:\Users\...→ broken). Normalizing to forward slashes fixes subtitle burning on Windows.2. feat: EDL-level
subtitle_style+ CJK phrase-level caption chunking (a8161f2)edl.jsonmay now carry asubtitle_styleASS force_style string, overridingSUB_FORCE_STYLEper project (different platforms/languages want different caption looks without patching the helper).天 天/气 不with orphaned punctuation. CJK text now accumulates into phrase-level cues (break on CJK punctuation or 10 chars), joined without spaces, punctuation-only tokens act as break markers and are never displayed. Latin behavior unchanged.3. fix: scale overlays to base resolution before compositing (c401166)
ffmpeg's
overlaycrops (not scales) oversized inputs. Full-res overlay assets rendered against--preview/--draftbases were silently cropped off-frame. Overlays are now scaled to the probed base dimensions first.4. feat: EDL-level
audio_filter+ strip all punctuation from CJK captions (d2a9485)edl.jsonaudio_filterruns before the 30ms edge fades in every segment extract — e.g.afftdndenoise or an EQ chain for muddy on-camera mics.Tested end-to-end on Windows 10 (Git Bash + PowerShell), ffmpeg 8.1.2, ElevenLabs Scribe zh transcription, 1728x3072 portrait sources: full pipeline transcribe → EDL → cutaway overlays + PIL animation slots → burned phrase-level Chinese subtitles → loudnorm.
🤖 Generated with Claude Code
Summary by cubic
Add CJK-friendly captions and per-project EDL overrides for subtitle style and audio processing, plus fix Windows subtitle path parsing and overlay cropping. Improves Chinese caption quality and makes Windows renders reliable.
New Features
subtitle_styleto override ASSforce_styleper project.audio_filterruns before the 30ms edge fades in segment extraction (e.g.,afftdn, EQ).Bug Fixes
Written for commit d2a9485. Summary will update on new commits.